| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ExplainProperty* and units |
| Date: | 2018-03-14 17:39:52 |
| Message-ID: | 6643.1521049192@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-03-14 13:32:10 -0400, Tom Lane wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> Only thing I wonder is if we shouldn't just *remove*
>>> ExplainPropertyLong and make ExplainPropertyInteger accept 64bits of
>>> input - the effort of passing and printing a 64bit integer will never be
>>> relevant for explain.
>> -0.5 ... everywhere else, we mean "int32" when we say "int", and I don't
>> think it's worth the potential confusion to do it differently here.
> So ExplainPropertyInt{32,64}?
I was thinking more of replacing ExplainPropertyLong with
ExplainPropertyInt64 and leaving ExplainPropertyInteger as-is.
Don't see the value in renaming that one just to rename it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-03-14 17:46:15 | Re: INOUT parameters in procedures |
| Previous Message | Andres Freund | 2018-03-14 17:35:47 | Re: ExplainProperty* and units |