| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PoC/WIP: Extended statistics on expressions |
| Date: | 2021-06-06 19:17:36 |
| Message-ID: | 660936.1623007056@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
> On 6/6/21 7:37 AM, Noah Misch wrote:
>> This added a "transformed" field to CreateStatsStmt, but it didn't mention
>> that field in src/backend/nodes. Should those functions handle the field?
> Yup, that's a mistake - it should do whatever CREATE INDEX is doing. Not
> sure if it can result in error/failure or just inefficiency (due to
> transforming the expressions repeatedly), but it should do whatever
> CREATE INDEX is doing.
I'm curious about how come the buildfarm didn't notice this. The
animals using COPY_PARSE_PLAN_TREES should have failed. The fact
that they didn't implies that there's no test case that makes use
of a nonzero value for this field, which seems like a testing gap.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-06-06 19:21:51 | Re: speed up verifying UTF-8 |
| Previous Message | Tomas Vondra | 2021-06-06 19:13:17 | Re: PoC/WIP: Extended statistics on expressions |