From: | <pokurev(at)pm(dot)nttdata(dot)co(dot)jp> |
---|---|
To: | <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | <robertmhaas(at)gmail(dot)com>, <amitlangote09(at)gmail(dot)com>, <pgsql-hackers(at)postgresql(dot)org>, <bannos(at)nttdata(dot)co(dot)jp> |
Subject: | Re: [PROPOSAL] VACUUM Progress Checker. |
Date: | 2016-03-09 07:54:27 |
Message-ID: | 65cff6c0028b4901aeaae6dc4769ceed@MP-MSGSS-MBX007.msg.nttdata.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Amit,
> -----Original Message-----
> From: Amit Langote [mailto:Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp]
> Sent: Wednesday, March 09, 2016 4:29 PM
> To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> Cc: robertmhaas(at)gmail(dot)com; amitlangote09(at)gmail(dot)com; SPS ポクレ ヴィ
> ナヤック(三技術) <pokurev(at)pm(dot)nttdata(dot)co(dot)jp>; pgsql-
> hackers(at)postgresql(dot)org; SPS 坂野 昌平(三技術) <bannos(at)nttdata(dot)co(dot)jp>
> Subject: Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.
>
> > On 2016/03/08 18:19, Kyotaro HORIGUCHI wrote:
> >> + WHEN 0 THEN 100::numeric(5, 2)
> >> + ELSE ((S.param3 + 1)::numeric / S.param2 *
> 100)::numeric(5, 2)
> >>
> >> This usage of numeric seems overkill to me.
> >
> > Hmm, how could this rather be written?
>
> OK, agreed about the overkill. Following might be better:
>
> + WHEN 0 THEN round(100.0, 2)
> + ELSE round((S.param3 + 1) * 100.0 / S.param2, 2)
+1
> Will update that patch.
>
> Thanks,
> Amit
>
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2016-03-09 08:09:27 | Re: extend pgbench expressions with functions |
Previous Message | Torsten Zühlsdorff | 2016-03-09 07:49:06 | Re: [HACKERS] How can we expand PostgreSQL ecosystem? |