| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: PATCH: Unlogged tables re-initialization tests |
| Date: | 2018-03-12 15:27:30 |
| Message-ID: | 65c7dbb0-2e6f-f97e-69d2-20d4fc781127@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/11/18 05:11, Michael Paquier wrote:
> On Fri, Mar 09, 2018 at 05:23:48PM -0500, Peter Eisentraut wrote:
>> This seems like a useful test.
>>
>> On 3/5/18 12:35, David Steele wrote:
>>> +mkdir($tablespaceDir)
>>> + or die "unable to mkdir \"$tablespaceDir\"";
>>
>> Use BAIL_OUT instead of die in tests.
>
> Would it be better to make this practice more uniform? From the code of
> the tests:
> $ git grep die -- */t/*.pl | wc -l
> 50
Yes, or maybe there is a way to "catch" die and turn it into BAIL_OUT?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2018-03-12 15:33:03 | Re: PATCH: Unlogged tables re-initialization tests |
| Previous Message | Nikita Glukhov | 2018-03-12 15:26:36 | Re: Jsonb transform for pl/python |