| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix SET EXPRESSION for virtual columns with whole-row dependencies |
| Date: | 2026-06-13 06:01:40 |
| Message-ID: | 65A70B05-E682-48AE-9EB2-D62ADBFB35D1@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jun 13, 2026, at 10:42, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> On Wed, Jun 10, 2026 at 5:06 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>
>>
>> After reading the other implementation in [1], I realized that I had missed the partial-index case, so I added coverage for that.
>>
>> I am still sending an updated version of this patch because my implementation is different from the one in [1]. I would like people to compare the two approaches and decide which direction is better.
>>
>
> I tried your patch before but abandoned it due to many regression test failures.
>
Thanks for looking. But I wonder which tests I missed?
I ran “make check-world” locally and passed. The CI tests all passed on the CF: https://commitfest.postgresql.org/patch/6867/
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Tatsuya Kawata | 2026-06-13 04:15:49 | [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope |