| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | some more pg_dump refactoring |
| Date: | 2020-06-23 12:57:23 |
| Message-ID: | 6594334b-40fd-14f1-6bc5-877afa3feed5@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here is a patch to reorganize dumpFunc() and dumpAgg() in pg_dump,
similar to daa9fe8a5264a3f192efa5ddee8fb011ad9da365. Instead of
repeating the almost same large query in each version branch, use one
query and add a few columns to the SELECT list depending on the
version. This saves a lot of duplication.
I have tested this with various old versions of PostgreSQL I had
available, but a bit more random testing with old versions would be welcome.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_dump-Reorganize-dumpFunc-and-dumpAgg.patch | text/plain | 22.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Kellerer | 2020-06-23 12:57:56 | Re: Decomposing xml into table |
| Previous Message | Bharath Rupireddy | 2020-06-23 12:52:01 | Re: [PATCH] Initial progress reporting for COPY command |