wrong comment in libpq.h

From: David Zhang <david(dot)zhang(at)highgo(dot)ca>
To: Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: wrong comment in libpq.h
Date: 2024-05-02 22:37:08
Message-ID: 65909efe-97c6-4863-af4e-21eb5a26dd1e@highgo.ca
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Hackers,

There is a comment like below in src/include/libpq/libpq.h,

 /*
  * prototypes for functions in be-secure.c
  */
extern PGDLLIMPORT char *ssl_library;
extern PGDLLIMPORT char *ssl_cert_file;

...

However, 'ssl_library', 'ssl_cert_file' and the rest are global
parameter settings, not functions. To address this confusion, it would
be better to move all global configuration settings to the proper
section, such as /* GUCs */, to maintain consistency.

I have attached an attempt to help address this issue.

Thank you,

David

Attachment Content-Type Size
0001-fix-the-wrong-comment-to-keep-the-consistency.patch text/plain 1.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-05-02 22:55:06 Re: enhance the efficiency of migrating particularly large tables
Previous Message Tomas Vondra 2024-05-02 21:37:06 Re: BitmapHeapScan streaming read user and prelim refactoring