Re: Question about src/timezone/zic.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Cochran <j69cochran(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Question about src/timezone/zic.c
Date: 2014-07-16 23:08:40
Message-ID: 6538.1405552120@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

John Cochran <j69cochran(at)gmail(dot)com> writes:
> [ useless code in zic.c ]

I agree with you that that function looks pretty pointless, but here's the
thing: that's not our code. Most of the code in src/timezone is taken
directly from the IANA tzcode distribution (see src/timezone/README), and
we're not very interested in diverging further from that upstream than
we have to. Doing so would just complicate merging future upstream fixes.

So if you want to pursue the question of whether eitol is worth its
weight, the right thing to do would be to ask about it on the upstream
mailing list (looks like tz at iana.org is the current list name).

One thing that *would* be worth doing is merging upstream's recent
updates; for all I know they've already dealt with this. According
to the README, we last synced with the 2010c tzcode release, so we're
short a few years worth of upstream bug fixes there.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2014-07-16 23:45:15 Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Previous Message Andres Freund 2014-07-16 22:26:29 Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED