Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help

From: Michael Banck <mbanck(at)gmx(dot)net>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [patch] pg_basebackup: mention that spread checkpoints are the default in --help
Date: 2023-10-19 20:30:04
Message-ID: 653191ce.170a0220.f28c.09f7@mx.google.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Oct 19, 2023 at 04:21:19PM +0300, Aleksander Alekseev wrote:
> > I believed that spread (not fast) checkpoints are the default in
> > pg_basebackup, but noticed that --help does not specify which is which -
> > contrary to the reference documentation.
> >
> > So I propose the small attached patch to clarify that.
>
> You are right and I believe this is a good change.
>
> Maybe we should also display the defaults for -X,
> --manifest-checksums, etc for consistency.

Hrm right, but those have multiple options and they do not enumerate
them in the help string as do -F and -c - not sure what general project
policy here is for mentioning defaults in --help, I will check some of
the other commands.

Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema 2023-10-19 20:47:19 Re: prevent non-superuser terminate bgworker running as superuser
Previous Message Robert Haas 2023-10-19 20:12:52 Re: Is this a problem in GenericXLogFinish()?