| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Amit Kapila <akapila(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command |
| Date: | 2021-06-02 23:17:58 |
| Message-ID: | 64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Commit 19890a064 changed pg_create_logical_replication_slot() to allow
decoding of two-phase transactions, but did not extend the
CREATE_REPLICATION_SLOT command to support it. Strangely, it does
extend the CreateReplicationSlotCmd struct to add a "two_phase" field,
but doesn't set it anywhere.
There were patches[1] from around the time of the commit to support
CREATE_REPLICATION_SLOT as well.
Is there a reason to support two-phase decoding, but not with the
replication protocol? If so, why change the CreateReplicationSlotCmd
structure as though we will support it?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-06-03 01:07:57 | Re: parent foreign tables and row marks |
| Previous Message | Tomas Vondra | 2021-06-02 23:02:17 | Re: Performance degradation of REFRESH MATERIALIZED VIEW |