| From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
|---|---|
| To: | "Mark Rofail" <markm(dot)rofail(at)gmail(dot)com>, "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Alexander Korotkov" <aekorotkov(at)gmail(dot)com>, "Andreas Karlsson" <andreas(at)proxel(dot)se>, "David Steele" <david(at)pgmasters(dot)net>, "Erik Rijkers" <er(at)xs4all(dot)nl>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Stephen Frost" <sfrost(at)snowman(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Zhihong Yu" <zyu(at)yugabyte(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2021-02-13 09:36:30 |
| Message-ID: | 64aa2dd6-cbd2-476a-84f7-d8be97558101@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Mark,
>On Fri, Feb 12, 2021, at 20:56, Mark Rofail wrote:
>Attachments:
>anyarray_anyelement_operators-v2.patch
Some more code review comments:
Comparing the v1 and v2 patch, I noticed this change in array_contains_elem():
+ oprresult = DatumGetBool(FunctionCallInvoke(locfcinfo));
-+ if (oprresult)
++ if (!locfcinfo->isnull && oprresult)
+ return true;
+ }
Is checking !locfcinfo->isnull due to something new in v2,
or what is just a correction for a problem also in v1?
/Joel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-02-13 10:12:26 | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Previous Message | Victor Yegorov | 2021-02-13 06:26:50 | Re: 64-bit XIDs in deleted nbtree pages |