| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Dave Page <dpage(at)postgresql(dot)org>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Oops - BF:Mastodon just died |
| Date: | 2008-01-31 14:47:42 |
| Message-ID: | 6494.1201790862@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> Agreed, but I suggest waiting till 8.4 is branched unless you are really
>>> sure about this addition. We freeze for 8.3.0 in less than 24 hours.
> I am pretty damn sure it's OK. It's pretty low risk (change an unlink
> call to a rename call) and even if it's broken as my fist version was,
> it doesn't appear to break the build. It's working on the buildfarm. I
> want it in so if we have problems with 8.3 we don't have to go through
> the handstands I had to to find out what was broken.
After looking at the patch, my only question is how all those junk files
get cleaned up at "make clean".
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2008-01-31 14:55:35 | Re: [PATCHES] Better default_statistics_target |
| Previous Message | Alvaro Herrera | 2008-01-31 14:47:26 | Remove pg_dump -i option (was Re: Proposed patch: synchronized_scanning GUC variable) |