| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <akapila(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| Date: | 2019-02-25 17:44:28 |
| Message-ID: | 649.1551116668@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I wrote:
> Amit Kapila <akapila(at)postgresql(dot)org> writes:
>> Avoid creation of the free space map for small heap relations, take 2.
> I think this patch still has some issues.
Just out of curiosity ... how can it possibly be even a little bit sane
that fsm_local_map is a single static data structure, without even any
indication of which table it is for?
If, somehow, there's a rational argument for that design, why is it
not explained in freespace.c? The most charitable interpretation of
what I see there is that it's fatally undercommented.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-02-26 00:56:16 | pgsql: Correct obsolete nbtree page deletion comment. |
| Previous Message | Tom Lane | 2019-02-25 17:02:00 | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2019-02-25 17:50:26 | Re: Remove Deprecated Exclusive Backup Mode |
| Previous Message | Li, Zheng | 2019-02-25 17:38:22 | Re: NOT IN subquery optimization |