| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Corner-case bug in pg_rewind |
| Date: | 2020-12-03 14:10:47 |
| Message-ID: | 6489f34a-0294-78b7-389b-37044afbe18f@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/12/2020 15:26, Ian Barwick wrote:
> On 02/12/2020 20:13, Heikki Linnakangas wrote:
>> Attached are two patches. The first patch is your original patch, unmodified
>> (except for a cosmetic rename of the test file). The second patch builds on
>> that, demonstrating and fixing the issue I mentioned. It took me a while to
>> create a repro for it, it's easily masked by incidental full-page writes or
>> because rows created by XIDs that are not marked as committed on the other
>> timeline are invisible, but succeeded at last.
>
> Aha, many thanks. I wasn't entirely sure what I was looking for there and
> recently haven't had the time or energy to dig any further.
Ok, pushed and backpatched this now.
Thanks!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2020-12-03 14:49:37 | Re: Corner-case bug in pg_rewind |
| Previous Message | Amit Kapila | 2020-12-03 13:56:13 | Re: Single transaction in the tablesync worker? |