| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
| Date: | 2017-05-22 14:47:49 |
| Message-ID: | 64818.1495464469@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
> On 2017-05-22 01:50, Tom Lane wrote:
>> Being lazy, I just wiped my copy and re-cloned, but it still seems the
>> same as before ... last commit on the pass3 branch is from Mar 4.
>> What branch should I be paying attention to?
> pass3 is the right branch. A fresh clone should have worked as in the
> attached log.
Ah, I now see that the code did change, I'd just been confused by
the "git log" history.
Small thought: shouldn't your updated code in pr_comment be changed to
- for (t_ptr = e_com + len - 1; t_ptr > e_com; t_ptr--)
+ for (t_ptr = e_com + len - 1; t_ptr >= e_com; t_ptr--)
Perhaps it's impossible for the character right at e_com to be a space,
but there seems no need for this loop to assume that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2017-05-23 08:23:40 | pgsql: Synced ecpg's pg_type.h with the one used in the backend. |
| Previous Message | Magnus Hagander | 2017-05-22 07:10:44 | pgsql: Fix typo in comment |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-05-22 15:30:48 | plpgsql, caching, resowners and jit |
| Previous Message | Chapman Flack | 2017-05-22 14:46:41 | Re: PG10 Crash-safe and replicable Hash Indexes and UNIQUE |