Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-31 16:45:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Mar 31, 2022 at 12:25 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Yeah, I think the fix is as simple as the attached.

> Well, that does not work because you added an extra parenthesis which
> makes Perl barf. If you fix that, then the test does not pass because,
> as I just explained to Tom, the flag we call --create-role doesn't
> create a role:

> error running SQL: 'psql:<stdin>:1: ERROR: role "backupuser" does not exist'

On looking closer, the combination of --config-auth and --create-role
*only* fixes the config files for SSPI, it doesn't expect the server
to be running.

I agree that the documentation of this is nonexistent and the design
is probably questionable, but I'm not volunteering to fix either.
If you are, step right up. In the meantime, I believe (without
having tested) that the correct incantation is to use auth_extra
but *also* create the user further down.

regards, tom lane

In response to


Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-03-31 16:50:41 Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Previous Message Robert Haas 2022-03-31 16:30:08 Re: pgsql: Add 'basebackup_to_shell' contrib module.

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2022-03-31 16:54:17 Re: psql - add SHOW_ALL_RESULTS option
Previous Message Fabrice Fontaine 2022-03-31 16:37:59 [PATCH] src/interfaces/libpq/Makefile: fix pkg-config without openssl