Re: Documentation improvements for partitioning

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Documentation improvements for partitioning
Date: 2017-02-21 02:01:25
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017/02/16 10:45, Amit Langote wrote:
> Also attaching 0002 (unchanged) for tab-completion support for the new
> partitioning syntax.

Robert already spawned a new thread titled "tab completion for
partitioning" for this [0].

> 0003 changes how ExecFindPartition() shows the row for which
> get_partition_for_tuple() failed to find a partition. As Simon commented
> upthread, we should show just the partition key, not the whole row in the
> error DETAIL. So the DETAIL now looks like what's shown by
> _bt_check_unique() upon uniqueness violation:
> DETAIL: Partition key of the failing row contains (key1, key2, ...)=(val1,
> val2, ...)
> The rules about which columns to show or whether to show the DETAIL at all
> are similar to those in BuildIndexValueDescription():
> - if user has SELECT privilege on the whole table, simply go ahead
> - if user doesn't have SELECT privilege on the table, check that they
> can see all the columns in the key (no point in showing partial key);
> however abort on finding an expression for which we don't try finding
> out privilege situation of whatever columns may be in the expression

I posted this patch in a new thread titled "error detail when partition
not found" [1].



In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2017-02-21 03:10:08 Re: Documentation improvements for partitioning
Previous Message Amit Langote 2017-02-21 01:58:47 error detail when partition not found