From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "ranier(dot)vf(at)gmail(dot)com" <ranier(dot)vf(at)gmail(dot)com>, chap(at)anastigmatix(dot)net |
Subject: | Re: Should we remove -Wdeclaration-after-statement? |
Date: | 2024-01-31 06:48:51 |
Message-ID: | 64156ca5-ed3c-4e78-bd99-fe513568bd44@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 29.01.24 16:03, Jelte Fennema-Nio wrote:
> I feel like this is the type of change where there's not much
> discussion to be had. And the only way to resolve it is to use some
> voting to gauge community opinion.
>
> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
> +1 to indicate support against/for the change.
>
> I'll start: +1
>
> Attached is a patch that removes -Wdeclaration-after-statement in the
> codebase. This is mainly to be able to add it to the commitfest, to
> hopefully get a decent amount of responses.
-1, mostly for the various reasons explained by others.
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2024-01-31 07:11:16 | Re: Some revises in adding sorting path |
Previous Message | Ashutosh Bapat | 2024-01-31 06:46:47 | Re: Incorrect cost for MergeAppend |