From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: crash with sql language partition support function |
Date: | 2018-04-13 10:14:09 |
Message-ID: | 63f99724-82cb-bce4-3a7a-7385f294edbf@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2018/04/13 3:10, Alvaro Herrera wrote:
> Alvaro Herrera wrote:
>
>> I'm dealing with this now -- will push shortly. The sane thing to do is
>> backpatch my previous memcxt fixes, since your patch introduces a
>> problem that we discussed with that other patch, namely that you would
>> leak the whole memory context if there is a problem while running the
>> function. I also noticed here that copy_partition_key is doing memcpy()
>> on the fmgr_info, which is bogus -- it should be using fmgr_info_copy.
>> Rather than patching that one piece it seems better to replace it
>> wholesale, since I bet this won't be the last time we'll hear about this
>> routine, and I would prefer not to deal with differently broken code in
>> the older branch.
>
> Pushed.
Thanks for fixing that.
Regards,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-04-13 10:20:40 | Re: crash with sql language partition support function |
Previous Message | Amit Langote | 2018-04-13 10:13:36 | Re: crash with sql language partition support function |