| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Add some const decorations to prototypes |
| Date: | 2017-11-04 13:14:33 |
| Message-ID: | 636e0869-7362-587e-0882-95085a7b1c52@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/3/17 13:54, Tom Lane wrote:
>> Would you prefer leaving the input argument as char *, or change the
>> endptr argument to const as well?
>
> Just leave it as char*. If you change the endptr argument you're going to
> force every call site to change their return variable, and some of them
> would end up having to cast away the const on their end.
OK, here is an updated patch with the controversial bits removed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-some-const-decorations-to-prototypes.patch | text/plain | 91.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-11-04 13:15:00 | Re: [HACKERS] pgsql: Fix freezing of a dead HOT-updated tuple |
| Previous Message | Fabien COELHO | 2017-11-04 11:34:52 | Re: pow support for pgbench |