| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, zuming(dot)jiang(at)inf(dot)ethz(dot)ch, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17995: Segmentation fault caused by UPDATE statement |
| Date: | 2023-06-26 04:27:08 |
| Message-ID: | 636983.1687753628@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Sun, Jun 25, 2023 at 06:00:00AM +0300, Alexander Lakhin wrote:
>> BTW, there is a commitfest entry to eliminate a bunch of other stack
>> overflow hazards (may be the fuzzer can find some of them too):
>> https://commitfest.postgresql.org/43/4239/
> Thanks for the pointer, I'll double-check that. Some of the locations
> of stack depth checks proposed involve performance-sensitive code
> paths, though, like mcxt.c :/
I hadn't looked at the patch yet, but ... mcxt.c? How is that recursive?
Even if there is some path that recurses through that, wouldn't the
check be better placed in a less-hot part of the loop?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-06-26 04:42:30 | Re: BUG #17993: FK issue on logical replication table |
| Previous Message | Michael Paquier | 2023-06-26 04:21:47 | Re: BUG #17995: Segmentation fault caused by UPDATE statement |