Re: PG regression with row comparison when btree_gist is enabled (BUG)

I only did some cursory tests, but the patch (applied to Macport's beta2 distribution) seems to be working on my dev box (OSX / Snow Leopard).

I'll report back if I run into oddities further down the road.

Thanks a lot!
Denis

>________________________________
>From: Jeff Davis <pgsql(at)j-davis(dot)com>
>To: oleg(at)sai(dot)msu(dot)su
>Cc: Denis de Bernardy <ddebernardy(at)yahoo(dot)com>; Teodor Sigaev <teodor(at)sigaev(dot)ru>; pgsql-bugs(at)postgresql(dot)org
>Sent: Sunday, June 19, 2011 7:23 PM
>Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
>
>On Sat, 2011-06-18 at 13:20 -0700, Jeff Davis wrote:
>> Interesting problem... the bug is in get_op_btree_interpretation() which
>> has code like this:
>>
>>  /*                                                                                               
>>    * If we can't find any opfamily containing the op, perhaps it is a
>> <>                           
>>    * operator.  See if it has a negator that is in an
>> opfamily.                                     
>>    */
>>  op_negated = false;
>>  if (catlist->n_members == 0)
>>
>>
>> However, that's a bogus test, because btree_gist puts <> into an
>> opfamily. Thus, catlist->n_members == 1 even though we really do need to
>> look for the negator. Really, we need to unconditionally search for the
>> operator as well as unconditionally searching for the negator.
>
>Patch attached.
>
>Regards,
>    Jeff Davis
>
>
>