Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Bryan Green <dbryan(dot)green(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain
Date: 2025-12-22 21:50:38
Message-ID: 634373.1766440238@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> That revealed another problem: Mkvcbuild.pm didn't add -lpgport. It
> looks out for the pattern PG_LIBS_INTERNAL = $(libpq_pgport), so
> that's an easy way to fix that -- is there a better way? I couldn't
> figure out how to tell it that we need libpqport but not libpq.

AFAICT from looking at v16 Mkvcbuild.pm, PG_LIBS_INTERNAL = $(libpq_pgport)
will do exactly what you want because that only triggers it to add
libpgport and libpgcommon (cf. lines 1053ff). I'm a little baffled
by that --- shouldn't it be pulling in libpq as well? But let's let
sleeping dogs lie.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-12-22 21:55:59 Re: psql: Fix tab completion for VACUUM option values
Previous Message Thomas Munro 2025-12-22 21:38:31 Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain