Re: [PATCH] Add GitLab CI to PostgreSQL

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Newhouse, Robin" <robinnew(at)amazon(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "Kekalainen, Otto" <ottoke(at)amazon(dot)com>
Subject: Re: [PATCH] Add GitLab CI to PostgreSQL
Date: 2023-07-05 13:22:30
Message-ID: 633b6d88-307e-2b5d-c90d-bc7dce486c0b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-07-04 Tu 19:44, Newhouse, Robin wrote:
>
> Hello!
>
> I propose the attached patch to be applied on the 'master' branch
>
> of PostgreSQL to add GitLab CI automation alongside Cirrus CI in the
> PostgreSQL repository.
>
> It is not intended to be a replacement for Cirrus CI, but simply
> suggestion for the
>
> PostgreSQL project to host centrally a Gitlab CI definition for those
> who prefer to use
>
> it while developing/testing PostgreSQL.
>
> The intent is to facilitate collaboration among GitLab users, promote
> standardization
>
> and consistency, and ultimately, improve testing and code quality.
>

This seems very RedHat-centric, which I'm not sure is a good idea. Also,
shouldn't at least some of these recipes call dnf and dnf-builddep
instead of yum and yum-build-dep?

If we're going to do this then arguably we should also be supporting
GitHub Actions and who knows what other CI frameworks. There is a case
for us special casing Cirrus CI because it's used for the cfbot.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2023-07-05 13:37:05 Re: logicalrep_message_type throws an error
Previous Message Andrew Dunstan 2023-07-05 12:49:39 Re: pg_basebackup check vs Windows file path limits