| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter <pmc(at)citylink(dot)dinoex(dot)sub(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
| Date: | 2020-01-11 21:42:31 |
| Message-ID: | 6317.1578778951@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
I wrote:
> (Still doesn't touch the static-buffer issue, though.)
And here's a delta patch for that. This fixes an additional portability
hazard, which is that there were various places doing stuff like
input.length = ntohl(*(uint32 *) PqGSSRecvBuffer);
That's a SIGBUS hazard on alignment-picky hardware, because there is
no guarantee that a variable that's just declared "char ...[...]"
will have any particular alignment. But malloc'ing the space will
provide maxaligned storage.
My FreeBSD testing has now given me enough confidence in these patches
that I'm just going to go ahead and push them. But, if you'd like to
do some more testing in advance of 12.2 release, please do.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| 0003-buffer-allocation-1.patch | text/x-diff | 9.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter | 2020-01-12 18:36:33 | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
| Previous Message | Tom Lane | 2020-01-11 20:37:43 | Re: 12.1 not useable: clientlib fails after a dozen queries (GSSAPI ?) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2020-01-11 22:02:50 | Re: Improve checking for pg_index.xmin |
| Previous Message | Alexander Korotkov | 2020-01-11 21:10:56 | Re: Avoid full GIN index scan when possible |