Re: [PATCH][BUG_FIX] Potential null pointer dereferencing.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH][BUG_FIX] Potential null pointer dereferencing.
Date: 2019-11-12 13:43:35
Message-ID: 630747A0-D258-4AF6-B6E1-3AFABDB2B990@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 12 Nov 2019, at 14:07, Ranier Vilela <ranier_gyn(at)hotmail(dot)com> wrote:

> ExecClearTuple don't check por NULL pointer arg and according
> TupIsNull slot can be NULL.

I assume you are referring to the TupIsNull(resultTupleSlot) check a few lines
down in the same loop? If resultTupleSlot was indeed NULL and not empty, the
subsequent call to ExecCopySlot would be a NULL pointer dereference too. I
might be missing something obvious, but in which case can resultTupleSlot be
NULL when calling ExecUnique?

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2019-11-12 14:03:53 RE: [PATCH][BUG_FIX] Potential null pointer dereferencing.
Previous Message Amit Kapila 2019-11-12 13:33:15 Re: [HACKERS] Block level parallel vacuum