Re: Avoid rescanning prefixes in appendStringLiteralDQ()

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid rescanning prefixes in appendStringLiteralDQ()
Date: 2026-11-19 12:59:06
Message-ID: 6302AC4E-CD2E-43C8-AE6E-A847BB86C74E@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 19, 2026, at 19:43, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> On 19/11/2026 08:32, Chao Li wrote:
>> While reviewing another patch, I spotted a trivial optimization in
>> appendStringLiteralDQ().
>> Looking at the code:
>> ```
>> /*
>> * Make sure we choose a delimiter which (without the trailing $) is not
>> * present in the string being quoted. We don't check with the trailing $
>> * because a string ending in $foo must not be quoted with $foo$.
>> */
>> while (strstr(str, delimBuf->data) != NULL)
>> {
>> appendPQExpBufferChar(delimBuf, suffixes[nextchar++]);
>> nextchar %= sizeof(suffixes) - 1;
>> }
>> ```
>>
>> The while loop always searches from the beginning of str. But
>> actually, a later search can just start from the previously returned
>> pointer. This function is currently only used by pg_dump. I don’t
>> expect a noticeable performance improvement in typical use, but it
>> seems to me to be a tiny but harmless optimization.
>
> Makes sense. There's a similar loop in pg_get_functiondef(), too. I applied the same optimization there, and pushed.
>
> - Heikki
>

Thanks a lot for applying this patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Heikki Linnakangas 2026-11-19 12:52:32 Re: Typos in smgr.c