| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch for ALTER DATABASE WITH TABLESPACE |
| Date: | 2008-11-07 14:36:32 |
| Message-ID: | 6300.1226068592@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Guillaume Lelarge <guillaume(at)lelarge(dot)info> writes:
> Bernd Helmle a crit :
>> Maybe this is nit-picking, but i see that you have to rmdir() an
>> existing empty tablespace directory to use copydir() afterwards. Maybe
>> we can teach copydir() to error out when trying to mkdir() an existing
>> directory only when forced by the caller? I see copydir() used at four
>> places, so the impact of this change would be minimal.
> I don't think this is nit-picking. I think about it too myself when I
> did v4 and v5. I wasn't so sure, I prefered not to change this function
> because it's used on important parts of the code (createdb and redo wal).
I like the v5 version better too.
Bernd, did you have any further comments? If not I'll get started on
this patch.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2008-11-07 14:44:04 | Re: Patch for ALTER DATABASE WITH TABLESPACE |
| Previous Message | Simon Riggs | 2008-11-07 13:50:18 | Re: Updates of SE-PostgreSQL 8.4devel patches (r1197) |