Refactoring postgres_fdw code to rollback remote transaction

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Refactoring postgres_fdw code to rollback remote transaction
Date: 2021-09-17 02:31:38
Message-ID: 62fbb63a-d46c-fb47-a56d-f6be1909aa44@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In postgres_fdw, pgfdw_xact_callback() and pgfdw_subxact_callback() do
almost the same thing to rollback remote toplevel- and sub-transaction.
But their such rollback logics are implemented separately and
in different way. Which would decrease the readability and maintainability,
I think. So how about making the common function so that those callback
functions can just use it? Patch attached.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
refactor_pgfdw_rollback_v1.patch text/plain 6.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2021-09-17 02:40:06 Re: Refactoring postgres_fdw code to rollback remote transaction
Previous Message Michael Paquier 2021-09-17 02:20:30 Re: Estimating HugePages Requirements?