Re: Rename of triggers for partitioned tables

From: Arne Roland <A(dot)Roland(at)index(dot)de>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rename of triggers for partitioned tables
Date: 2020-11-27 00:19:57
Message-ID: 62ebc64869794398bfe46844aaa6ba15@index.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm sorry for the spam. Here a patch with updated comments, I missed one before.

Regards

Arne

________________________________
From: Arne Roland <A(dot)Roland(at)index(dot)de>
Sent: Friday, November 27, 2020 1:05:02 AM
To: Pg Hackers
Subject: Re: Rename of triggers for partitioned tables

I'm too unhappy with the interface change, so please view attached patch instead.

Regards

Arne

________________________________
From: Arne Roland <A(dot)Roland(at)index(dot)de>
Sent: Friday, November 27, 2020 12:28:31 AM
To: Pg Hackers
Subject: Rename of triggers for partitioned tables

Hello,

I got too annoyed at building queries for gexec all the time. So wrote a patch to fix the issue that the rename of partitioned trigger doesn't affect children.

In case there isn't a dependent trigger with the same name on the child the function errors out. If the user touched the trigger of the child, it's not a sensitive idea to mess with it.

I'm not happy with the interface change in trigger.h. Yet I don't like the idea of creating another layer of indirection either.

Even though it's a small patch, there might be other things I'm missing, so I'd appreciate feedback.

Regards

Arne

Attachment Content-Type Size
recursive_tgrename.2.patch text/x-patch 6.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-11-27 00:30:40 Re: Allow some recovery parameters to be changed with reload
Previous Message David Rowley 2020-11-27 00:10:43 Re: Hybrid Hash/Nested Loop joins and caching results from subplans