| From: | "Andy Fan" <zhihuifan1213(at)163(dot)com> |
|---|---|
| To: | "Michael Paquier" <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, thomas(dot)munro(at)gmail(dot)com |
| Subject: | Re:Re: A out of date comment of WaitForWALToBecomeAvailable |
| Date: | 2026-01-30 10:23:00 |
| Message-ID: | 62c18fcd.85b1.19c0e6d7683.Coremail.zhihuifan1213@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2026-01-30 13:13:37, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
Hi,
>On Fri, Jan 30, 2026 at 10:29:41AM +0800, Andy Fan wrote:
>> The following comment looks out of date now. should we fix it as following?
>
>Yes, the code returns XLREAD_FAIL is we cannot find a record when not
>in standby mode. Thanks for the report.
Thanks for double check. patch attached.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-out-of-date-comment-in-WaitForWALToBecomeAvai.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-01-30 11:09:34 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | jian he | 2026-01-30 10:10:47 | Re: Can we remove support for standard_conforming_strings = off yet? |