| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | sk(at)zsrv(dot)org, david(at)nlpgo(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column. |
| Date: | 2018-01-18 07:57:38 |
| Message-ID: | 62C2B9A0-51BC-40FF-9BCA-F203784CB9C1@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Hello!
> 18 янв. 2018 г., в 10:48, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> написал(а):
>
> Gist imposes the ninth strategy to perform index only scan but
> planner is not considering that
> ....
> Please find the attached patch.
I agree with you that current behavior is a bug and your patch seems correct.
I'm a bit worried about ninth strategy words: fetch is not necessary now, if opclass lacks compress methods - index only scan is possible. See https://github.com/postgres/postgres/commit/d3a4f89d8a3e500bd7c0b7a8a8a5ce1b47859128 for details.
Though there are tests in cube and seg for that, if your patch passes check-world, than this behavior is not affected.
Thank you for the patch!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-01-18 08:25:05 | Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column. |
| Previous Message | Kyotaro HORIGUCHI | 2018-01-18 05:48:51 | Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2018-01-18 08:18:12 | Re: GSoC 2018 |
| Previous Message | Etsuro Fujita | 2018-01-18 07:20:39 | Re: [HACKERS] Reorder header files in alphabetical order |