| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Erik Wienhold <ewie(at)ewie(dot)name> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Treat <rob(at)xzilla(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Regression with large XML data input |
| Date: | 2025-07-28 20:16:07 |
| Message-ID: | 628881.1753733767@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> I've not looked at the details of the proposed patches, but will
> do so now that the direction to go in is apparent.
Erik's v2 is slightly wrong as to the save-and-restore logic for
the KeepBlanks setting: we need to restore in the error path too,
and we'd better mark the save variable volatile since it's modified
inside the PG_TRY. I made some other cosmetic changes, mainly to
avoid calculating "options" when it won't be used. I tested the
attached v3 against RHEL8's libxml2-2.9.7, as well as against today's
libxml2 git master, and it accepts the problematic input on both.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v3-fix-xml2-regression.patch | text/x-diff | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitrios Apostolou | 2025-07-28 20:41:54 | Re: [PING] fallocate() causes btrfs to never compress postgresql files |
| Previous Message | Tom Lane | 2025-07-28 20:08:03 | Re: Making pgfdw_report_error statically analyzable |