| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pg_createsubscriber: allow duplicate subscription names |
| Date: | 2026-09-07 03:34:21 |
| Message-ID: | 622D7351-BAC4-45D8-861F-B065301292A0@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sep 5, 2026, at 11:24, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>
> Hi Chao,
>
> I reviewed v3 and also ran a real (non --dry-run) pg_createsubscriber
> with the same --subscription name for two databases plus distinct
> --replication-slot names. Both subscriptions were created in their
> respective databases, the slots were created on the publisher, and
> subsequent inserts replicated correctly. 040_pg_createsubscriber
> passes as well.
>
> v3 LGTM and -> Ready for commiter.
>
> Thanks,
> Shihao
Thanks a lot for the review.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-09-07 03:36:40 | RE: pg_createsubscriber does not check output_plugin_libraries |
| Previous Message | Tom Lane | 2026-09-07 03:21:27 | Re: SUM(int2)/SUM(int4) do not detect overflow of the int8 accumulator |