Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Matheus de Oliveira <matioli(dot)matheus(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] btree_gin, add support for uuid, bool, name, bpchar and anyrange types
Date: 2018-04-05 15:23:04
Message-ID: 62067d82-a45e-c5b2-96a9-4b9f76365a23@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks to everyone, first patch is pushed.

Range opclass seems unusable because comparing function is close to dummy and
BTree opclass is only useful to implement unique check constraint. So, for range
it should different index structure to be useful.

Matheus de Oliveira wrote:
>
>
> On Thu, Apr 5, 2018 at 8:16 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru
> <mailto:teodor(at)sigaev(dot)ru>> wrote:
>
> somehow you missed some parts in 0001 patch, at least regression tests fail:
>
>   CREATE EXTENSION btree_gin;
> + ERROR:  could not find function "gin_extract_value_uuid" in file
> "/usr/local/pgsql/lib/btree_gin.so"
>
>
> Ouch... My fault, filterdiff is acting weird for some reason...
>
> Here is the corrected versions... I tested here applying on a clean master just
> to be sure, all looks good.
>
> Very sorry about that mess. I hope it can get in v11, it is a patch so simple,
> but so useful for many people.
>
> Best regards,
> --
> Matheus de Oliveira
>
>

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-04-05 15:30:03 Re: WIP: a way forward on bootstrap data
Previous Message Alvaro Herrera 2018-04-05 15:09:15 Re: [HACKERS] MERGE SQL Statement for PG11