Re: Add recovery to pg_control and remove backup_label

From: David Steele <david(at)pgmasters(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add recovery to pg_control and remove backup_label
Date: 2023-11-21 17:41:15
Message-ID: 62013cd7-b2a6-477e-b8dd-9a27be3073e0@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/20/23 16:41, Andres Freund wrote:
>
> On 2023-11-20 15:56:19 -0400, David Steele wrote:
>> I understand this is an option -- but does it need to be? What is the
>> benefit of excluding the manifest?
>
> It's not free to create the manifest, particularly if checksums are enabled.

It's virtually free, even with the basic CRCs. Anyway, would you really
want a backup without a manifest? How would you know something is
missing? In particular, for page incremental how do you know something
is new (but not WAL logged) if there is no manifest? Is the plan to just
recopy anything not WAL logged with each incremental?

> Also, for external backups, there's no manifest...

There certainly is a manifest for many external backup solutions. Not
having a manifest is just running with scissors, backup-wise.

Regards,
-David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-11-21 17:59:18 Re: Add recovery to pg_control and remove backup_label
Previous Message vignesh C 2023-11-21 17:33:36 Re: pg_upgrade and logical replication