|From:||Andrew Dunstan <andrew(at)dunslane(dot)net>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>|
|Cc:||Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>|
|Subject:||Re: pgsql: Add 'basebackup_to_shell' contrib module.|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 3/31/22 11:32, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Mar 31, 2022 at 10:52 AM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> We should probably fix the test though, so it doesn't require Unix
>>> sockets. It should be possible, although I haven't looked yet to see how.
>> Our mutual colleague Neha Sharma pointed out this email message to me:
Yep, that's kinda what I was expecting.
>> I actually don't understand why using pg_regress --auth-extra would
>> fix it, or what that option does, or why we're even running pg_regress
>> at all in PostgreSQL::Test::Cluster::init. I think it might be to fix
>> this exact issue, but there's no SGML documentation for pg_regress,
I really don't know why this stuff is in pg_regress at all. It seems
rather odd to me and it's annoyed me for a while. But that's a fight for
> I'm not volunteering to fix that, but this comment in pg_regress.c
> is probably adequately illuminating:
> * Rewrite pg_hba.conf and pg_ident.conf to use SSPI authentication. Permit
> * the current OS user to authenticate as the bootstrap superuser and as any
> * user named in a --create-role option.
> This script is creating users manually rather than letting the TAP
> infrastructure do it, which is an antipattern.
Yeah, I think the fix is as simple as the attached.
|Next Message||Robert Haas||2022-03-31 16:30:08||Re: pgsql: Add 'basebackup_to_shell' contrib module.|
|Previous Message||Andres Freund||2022-03-31 16:10:02||Re: pgsql: Add 'basebackup_to_shell' contrib module.|
|Next Message||Robert Haas||2022-03-31 16:26:46||Re: head fails to build on SLES 12 (wal_compression=zstd)|
|Previous Message||Andres Freund||2022-03-31 16:25:18||Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints|