| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Update comment in ExecPartitionCheck |
| Date: | 2017-07-04 08:55:29 |
| Message-ID: | 61e213a1-6996-4dee-2210-53798df625a3@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This comment in an error handling in ExecPartitionCheck():
if (!ExecCheck(resultRelInfo->ri_PartitionCheckExpr, econtext))
{
char *val_desc;
Relation orig_rel = rel;
/* See the comment above. */
if (resultRelInfo->ri_PartitionRoot)
should be updated because we don't have any comment on that above in the
code. Since we have a comment on that in ExecConstraints() defined just
below that function, I think the comment should be something like this:
"See the comment in ExecConstraints().". Attached is a patch for that.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| ExecPartitionCheck-comment-fix.patch | text/plain | 502 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2017-07-04 09:08:31 | Re: UPDATE of partition key |
| Previous Message | Etsuro Fujita | 2017-07-04 08:25:17 | Re: UPDATE of partition key |