| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Adam Lee <ali(at)pivotal(dot)io> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
| Subject: | Re: Add LogicalTapeSetExtend() to logtape.c |
| Date: | 2020-02-28 20:38:55 |
| Message-ID: | 619e61919fd604c2caa629536ee87615b732e054.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2020-02-28 at 14:16 +0800, Adam Lee wrote:
> I noticed another difference, I was using palloc0(), which could be
> one of the
> reason, but not sure.
I changed the palloc0()'s in your code to plain palloc(), and it didn't
make any perceptible difference. Still slower than the version I posted
that keeps the flexible array.
Did you compare all 3? Master, with your patch, and with my patch? I'd
like to see if you're seeing the same thing that I am.
> Tested your hashagg-20200226.patch on my laptop(Apple clang version
> 11.0.0),
> the average time is 25.9s:
That sounds high -- my runs are about half that time. Is that with a
debug build or an optimized one?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-02-28 20:54:16 | Re: Portal->commandTag as an enum |
| Previous Message | Tom Lane | 2020-02-28 18:59:49 | Re: Allowing ALTER TYPE to change storage strategy |