| From: | "sergei sh(dot)" <sshoulbakov(at)kontur(dot)io> |
|---|---|
| To: | Aliaksandr Kalenik <akalenik(at)kontur(dot)io> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] reduce page overlap of GiST indexes built using sorted method |
| Date: | 2022-01-18 20:26:05 |
| Message-ID: | 612e90c2-4aac-2919-51e3-f905975656b7@kontur.io |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I've addressed Andrey Borodin's concerns about v2 of this patch by
Aliaksandr
Kalenik in attached version. Change list:
* Number of pages to collect moved to GUC parameter
"gist_sorted_build_page_buffer_size".
* GistSortedBuildPageState type renamed to GistSortedBuildLevelState.
* Comments added.
Sorted build remaind deterministic as long as picksplit implementation
for given
opclass is, which seem to be true for builtin types, so setting random
seed is
not required for testing.
Andrey Borodin's GiST support patch for amcheck was used to verify built
indexes:
https://commitfest.postgresql.org/25/1800/
PSA modified version working with current Postgres code (btree functions
removed).
| Attachment | Content-Type | Size |
|---|---|---|
| 03_reduce_page_overlap_of_gist_indexes_built_using_sorted_method.patch | text/x-patch | 17.3 KB |
| v1-amcheck-gist-no-btree.patch | text/x-patch | 26.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-18 20:41:02 | Re: Allow root ownership of client certificate key |
| Previous Message | Juan José Santamaría Flecha | 2022-01-18 20:08:37 | Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree |