Re: [PATCH] reduce page overlap of GiST indexes built using sorted method

From: Andres Freund <andres(at)anarazel(dot)de>
To: "sergei sh(dot)" <sshoulbakov(at)kontur(dot)io>
Cc: Aliaksandr Kalenik <akalenik(at)kontur(dot)io>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] reduce page overlap of GiST indexes built using sorted method
Date: 2022-01-23 22:17:15
Message-ID: 20220123221715.mp4dgtyhzsbeusss@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-01-18 23:26:05 +0300, sergei sh. wrote:
> I've addressed Andrey Borodin's concerns about v2 of this patch by
> Aliaksandr
> Kalenik in attached version. Change list:
> * Number of pages to collect moved to GUC parameter
> "gist_sorted_build_page_buffer_size".
> * GistSortedBuildPageState type renamed to GistSortedBuildLevelState.
> * Comments added.

Unfortunately the tests don't seem to pass on any platform, starting with this
version:
https://cirrus-ci.com/build/4808414281859072

Presumably the fault of v1-amcheck-gist-no-btree.patch, which comments out
some functions. I assume that patch isn't intended to be part of the
submission?

https://wiki.postgresql.org/wiki/Cfbot#Which_attachments_are_considered_to_be_patches.3F

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-23 22:26:53 Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Previous Message Andres Freund 2022-01-23 22:11:16 Re: pg_basebackup fsyncs some files despite --no-sync (was: Adding CI to our tree)