| From: | Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jim Nasby <jnasby(at)upgrade(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Andrei Zubkov <zubkov(at)moonset(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, a(dot)lepikhov(at)postgrespro(dot)ru, Sami Imseih <samimseih(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Vacuum statistics |
| Date: | 2025-09-25 13:53:09 |
| Message-ID: | 612819ad-beca-41fb-bb7f-d5a7c11f0045@yandex.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi! Thank you for reviewing it.
My email hasn’t been working properly recently, so I missed your letter
— sorry about that.
Yes, I completely agree with your proposed fix and have included it in
the updated version of the patch.
Just to remind you, this version stores vacuum statistics separately in
the cumulative system due to the issue with disabling the gathering of
vacuum statistics.
The patch had some conflicts with the current master branch, but I’ve
resolved them and now it applies cleanly without conflicts.
On 15.09.2025 23:46, Ilia Evdokimov wrote:
>
> Right now there is a bug: when I run a simple
>
> SELECT * FROM pg_stat_vacuum_database;
>
> psql crashes.
>
> The root cause is an incorrect zeroing of a local variable:
> PgStat_VacuumDBCounts allzero;
> - memset(&allzero, 0, sizeof(PgStat_VacuumRelationCounts));
> + memset(&allzero, 0, sizeof(PgStat_VacuumDBCounts));
>
> --
> Best regards,
> Ilia Evdokimov,
> Tantor Labs LLC,
> https://tantorlabs.com
>
>
>
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| v25-0001-Machinery-for-grabbing-an-extended-vacuum-statistics.patch | text/x-patch | 71.5 KB |
| v25-0002-Machinery-for-grabbing-an-extended-vacuum-statistics.patch | text/x-patch | 54.6 KB |
| v25-0003-Machinery-for-grabbing-an-extended-vacuum-statistics.patch | text/x-patch | 30.8 KB |
| v25-0004-Vacuum-statistics-have-been-separated-from-regular-r.patch | text/x-patch | 93.8 KB |
| v25-0005-Add-documentation-about-the-system-views-that-are-us.patch | text/x-patch | 24.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2025-09-25 13:55:08 | Missing parentheses |
| Previous Message | Tom Lane | 2025-09-25 13:43:24 | Re: plan shape work |