| From: | Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> |
|---|---|
| To: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: Fix parallel vacuum buffer usage reporting |
| Date: | 2024-04-20 12:00:53 |
| Message-ID: | 611de844-d3f6-4395-9042-5c76203b7250@yandex.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, thank you for your work with this subject.
While I was reviewing your code, I noticed that your patch conflicts
with another patch [0] that been committed.
On 28.03.2024 13:12, Anthonin Bonnefoy wrote:
> Hi,
>
> Thanks for the review.
> On Thu, Mar 28, 2024 at 4:07 AM Masahiko Sawada
> <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> As for the proposed patch, the following part should handle the
> temp tables too:
>
>
> True, I've missed the local blocks. I've updated the patch:
> - read_rate and write_rate now include local block usage
> - I've added a specific output for reporting local blocks instead of
> combining them in the same output.
>
> Regards,
> Anthonin
--
Regards,
Alena Rybakina
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anton A. Melnikov | 2024-04-20 13:20:35 | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Previous Message | Alexander Lakhin | 2024-04-20 11:00:00 | Performance of JSON_TABLE vs jsonb_to_recordset |