Re: [19] CREATE SUBSCRIPTION ... SERVER

On Wed, 2026-02-04 at 13:53 +0900, Masahiko Sawada wrote:
> I've reviewed the latest patch set. I understand the motivation
> behind
> this proposal and find it useful.

Thank you, that's important feedback.

> The documentation for ALTER FOREIGN DATA WRAPPER needs to be updated.

Done.

> ---
> The security section[1] of logical replication chapter would also
> need
> to be updated.

Done.

> We might want to mention in the documentation of CREATE SERVER[2]
> that
> a foreign server's name can be used to connect publication in CREATE
> SUBSCRIPTION as we have a similar description for dblink_connect():

Done.

> ---
> dblink_connect() function can retrieve the connection string from a
> foreign server specified in the second argument, which is a very
> similar use case to CREATE SUBSCRIPTION. Should we make dblink use
> the
> new function ForeignServerConnectionString() to get the connection
> string (in get_connect_string())?

ForeignServerConnectionString() goes through the new FDW
connection_function, whereas dblink builds the string itself.
Technically, changing that could break things, but overall it seems to
make sense. I added this as a separate commit.

> ---
> It would be better to enhance psql's \dRs command to show the server
> name specified in the subscription.

Good idea, done.

Regards,
Jeff Davis