| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-07-20 21:02:08 |
| Message-ID: | 60E1B06A-4393-4101-9D8E-F4DDF8E7A09E@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 20 Jul 2018, at 17:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> No objections, if you want to make the effort. But IMHO the lseek+read
>> fallback is good enough on Windows. Unless you were thinking that we
>> could then remove the !HAVE_PREAD fallback altogether. Are there any
>> other platforms out there that don't have pread/pwrite that we care about?
>
> AFAICT, macOS has them as far back as we care about (prairiedog does).
> HPUX 10.20 (gaur/pademelon) does not, so personally I'd like to keep
> the lseek+read workaround. Don't know about the oldest Solaris critters
> we have in the buildfarm. FreeBSD has had 'em at least since 4.0 (1994);
> didn't check the other BSDen.
The OpenBSD box I have access to has pwrite/pread, and have had for some time
if I read the manpage right.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tels | 2018-07-20 21:18:13 | Re: Non-portable shell code in pg_upgrade tap tests |
| Previous Message | Andres Freund | 2018-07-20 20:55:41 | Re: Possible performance regression in version 10.1 with pgbench read-write tests. |