Re: Fix typo 586/686 in atomics/arch-x86.h

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Fix typo 586/686 in atomics/arch-x86.h
Date: 2026-05-18 16:17:22
Message-ID: 60D08F6B-6B4E-43A2-A12C-548FC6D2BA1D@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 May 2026, at 07:31, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Fri, May 08, 2026 at 09:32:16AM +0200, Daniel Gustafsson wrote:
>> On 7 May 2026, at 23:46, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>>> To be clear, I'm +1 on removing any 32-bit code in this file. But the
>>> 64-bit stuff should probably be fixed.
>>
>> Agreed. Reading over the threads you linked it seems the way forward is to
>> apply the patch posted here, and then fix arch detection so that atomics.h
>> picks up the right code for x86-64.
>
> +1

Done.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2026-05-18 16:28:26 Re: relfilenode statistics
Previous Message Enrique Sánchez 2026-05-18 16:09:03 Extended statistics improvement: multi-column MCV missing values