Re: Remove condition variables from injection wait logic.

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove condition variables from injection wait logic.
Date: 2025-08-21 06:57:04
Message-ID: 60BFCA5C-F170-4219-822D-2958C31AA4BB@yandex-team.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 21 Aug 2025, at 04:02, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> I would not object to that if that's the actual consensus as we don't
> have a strong requirement for condition variables when it comes to
> testing. That's just a more efficient implementation, and it makes
> the tests faster. If we do that, I'd suggest to choose a cap and a
> variable wait time, that increases across iterations to still make the
> wait more responsive on faster machines.

I want to do a test for suspected VM corruption (1).
I need a way to do injection point that can be kill-9-ed without corruption.
So I can just use Kirill's patch to develop my test, thanks! I do not need it committed until the work is over.

So far there are no tests in the tree that need this functionality in injection points.
And even when we will have such a test that needs this kind of sleep, it is only required if injection point is in critical section. Not for every injection point wait.

Also, CondVar might be fixed and allowed to be used in critical section (2). AIO needs it anyway.

Let's wait for (1) or (2), then decide if we need to do something with injection point waiting.

Thanks you both for working on these tools!

Best regards, Andrey Borodin.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Corey Huinker 2025-08-21 07:19:40 Re: vacuumdb --missing-stats-only and permission issue
Previous Message Fujii Masao 2025-08-21 06:52:10 Re: Standardize LSN-based filename