| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Performance improvements for src/port/snprintf.c |
| Date: | 2018-10-03 18:36:54 |
| Message-ID: | 6094.1538591814@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
>> Hm. I guess that'd be a bit better, but I'm not sure it's worth it. How
>> about we simply add a static assert that long long isn't bigger than
>> int64?
> WFM, I'll make it happen.
Actually, while writing a comment to go with that assertion, I decided
this was dumb. If we're expecting the compiler to have "long long",
and if we're convinced that no platforms define "long long" as wider
than 64 bits, we may as well go with the s/int64/long long/g solution.
That should result in no code change on any platform today. And it
will still work correctly, if maybe a bit inefficiently, on some
hypothetical future platform where long long is wider. We (or our
successors) can worry about optimizing that when the time comes.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-10-03 18:48:59 | Re: Performance improvements for src/port/snprintf.c |
| Previous Message | Andres Freund | 2018-10-03 18:35:52 | Re: Performance improvements for src/port/snprintf.c |