From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: __pg_log_level in anonynous enum should be initialized? (Was: pgsql: Change SHA2 implementation based on OpenSSL to use EVP digest ro) |
Date: | 2020-09-29 13:29:18 |
Message-ID: | 607460.1601386158@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Sep 28, 2020 at 12:49:29PM -0400, Tom Lane wrote:
>> Since prairiedog is not likely to be around forever, I propose that
>> we ought to enforce this going forward by arranging for common/logging.c
>> to not get built into the libpgcommon_shlib library variant.
> Agreed. This makes sense in the long term, so attached is a proposal
> of patch. I did not really see the point in complicating the MSVC
> scripts for that though. The new variable names look natural to me
> like that, the new comment may need some tweaks.
Hm, it doesn't seem like "OBJS_PGCOMMON" conveys much. I think
OBJS_FRONTEND ought to be the set of files built for frontend
application use (i.e., libpgcommon.a), so we need a new name
for what will go into libpgcommon_shlib.a. Maybe OBJS_SHLIB,
or to be even more explicit, OBJS_FRONTEND_SHLIB.
As for the comment, maybe "logging.c is excluded from OBJS_SHLIB
as a matter of policy, because it is not appropriate for general
purpose libraries such as libpq to report errors directly."
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-09-29 15:18:47 | pgsql: Fix memory leak in plpgsql's CALL processing. |
Previous Message | Alexander Korotkov | 2020-09-29 09:01:15 | pgsql: Support for ISO 8601 in the jsonpath .datetime() method |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-09-29 13:30:33 | Re: Optimize memory allocation code |
Previous Message | Amit Kapila | 2020-09-29 13:16:03 | Re: [HACKERS] logical decoding of two-phase transactions |