Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Kris Jurka <books(at)ejurka(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align
Date: 2006-02-10 19:13:26
Message-ID: 604.1139598806@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> Does PostgreSQL have a policy on the signedness of strings?

For the most part we say "char" where we can and "unsigned char" only
where it really matters, which is mostly inside code that's
encoding-aware anyway.

It was only fairly recently that we cleaned the code up to avoid
signedness warnings, but now that that's done I don't want to backtrack
on it. What I'd suggest is taking a close look at the set of functions
you have and trying to identify a layer that should be "unsigned char"
versus upper layers that can just say "char".

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Martijn van Oosterhout 2006-02-10 21:49:12 Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align
Previous Message Tom Lane 2006-02-10 19:01:34 pgsql: Change search for default operator classes so that it examines

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2006-02-10 19:16:41 Re: Scrollable cursors and Sort performance
Previous Message Michael Paesold 2006-02-10 19:06:53 Spaces in psql output (Was: FW: PGBuildfarm member snake Branch HEAD Status changed)